Skip to content

fix: logging missing config #1873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2023
Merged

fix: logging missing config #1873

merged 1 commit into from
Apr 25, 2023

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Apr 25, 2023

No description provided.

@csviri csviri requested a review from metacosm April 25, 2023 12:22
@csviri csviri self-assigned this Apr 25, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

metacosm
metacosm approved these changes Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was originally done to avoid adding the slf4j dependency to the core module but I guess it's been added for a while.

@csviri csviri merged commit b5d71c2 into main Apr 25, 2023
@csviri csviri deleted the main-loggingfix branch April 25, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm metacosm approved these changes

Assignees

@csviri csviri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csviri @metacosm